This is an automated email from the ASF dual-hosted git repository.

robertlazarski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/axis-axis2-java-rampart.git


The following commit(s) were added to refs/heads/master by this push:
     new a2fad10c Stop logging the signature key password and secured envelopes
a2fad10c is described below

commit a2fad10cd1edade7a101c10dd9b44aecc4aec2da
Author: Robert Lazarski <[email protected]>
AuthorDate: Sat Nov 7 03:56:12 2026 -1000

    Stop logging the signature key password and secured envelopes
    
    BindingBuilder logged the signature key password at debug level, and
    MessageBuilder and RampartEngine dumped whole envelopes, whose security
    header can carry a plaintext UsernameToken password, to their class
    loggers. Envelope tracing remains available through the opt-in
    org.apache.rampart.MESSAGE logger.
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
---
 .../src/main/java/org/apache/rampart/MessageBuilder.java   | 14 ++++----------
 .../src/main/java/org/apache/rampart/RampartEngine.java    | 12 ------------
 .../java/org/apache/rampart/builder/BindingBuilder.java    |  3 ---
 3 files changed, 4 insertions(+), 25 deletions(-)

diff --git 
a/modules/rampart-core/src/main/java/org/apache/rampart/MessageBuilder.java 
b/modules/rampart-core/src/main/java/org/apache/rampart/MessageBuilder.java
index e4b3450a..c9a8e448 100644
--- a/modules/rampart-core/src/main/java/org/apache/rampart/MessageBuilder.java
+++ b/modules/rampart-core/src/main/java/org/apache/rampart/MessageBuilder.java
@@ -267,17 +267,11 @@ public class MessageBuilder {
        }
 
 
-       // Log the final envelope being built
+       // Do not log the secured envelope: its security header can carry a
+       // plaintext UsernameToken password. Envelope tracing belongs to the
+       // opt-in org.apache.rampart.MESSAGE logger only.
        if (log.isDebugEnabled()) {
-           try {
-               log.debug("=== MESSAGEBUILDER: Final SOAP envelope being sent 
===");
-               log.debug("MessageBuilder: Action = " + msgCtx.getWSAAction());
-               log.debug("MessageBuilder: Final envelope content:");
-               log.debug(msgCtx.getEnvelope().toString());
-               log.debug("=== END SOAP envelope ===");
-           } catch (Exception e) {
-               log.debug("MessageBuilder: Could not log envelope: " + 
e.getMessage());
-           }
+           log.debug("MessageBuilder: Action = " + msgCtx.getWSAAction());
        }
 
        /*
diff --git 
a/modules/rampart-core/src/main/java/org/apache/rampart/RampartEngine.java 
b/modules/rampart-core/src/main/java/org/apache/rampart/RampartEngine.java
index c8897f17..823d4881 100644
--- a/modules/rampart-core/src/main/java/org/apache/rampart/RampartEngine.java
+++ b/modules/rampart-core/src/main/java/org/apache/rampart/RampartEngine.java
@@ -78,12 +78,6 @@ public class RampartEngine {
 
                if (log.isDebugEnabled()) {
                        log.debug("RampartEngine: Processing incoming message");
-                       log.debug("RampartEngine: Initial SOAP envelope 
received:");
-                       try {
-                               log.debug(msgCtx.getEnvelope().toString());
-                       } catch (Exception e) {
-                               log.debug("RampartEngine: Could not log initial 
envelope: " + e.getMessage());
-                       }
                }
 
                if (log.isDebugEnabled()) {
@@ -263,12 +257,6 @@ public class RampartEngine {
                if(secHeader == null) {
                    if (log.isDebugEnabled()) {
                        log.debug("RampartEngine: No security header found in 
received message");
-                       log.debug("RampartEngine: Received SOAP envelope:");
-                       try {
-                           log.debug(msgCtx.getEnvelope().toString());
-                       } catch (Exception e) {
-                           log.debug("RampartEngine: Could not log envelope: " 
+ e.getMessage());
-                       }
                    }
                    throw new RampartException("missingSecurityHeader");
                }
diff --git 
a/modules/rampart-core/src/main/java/org/apache/rampart/builder/BindingBuilder.java
 
b/modules/rampart-core/src/main/java/org/apache/rampart/builder/BindingBuilder.java
index b5124783..6b62e721 100644
--- 
a/modules/rampart-core/src/main/java/org/apache/rampart/builder/BindingBuilder.java
+++ 
b/modules/rampart-core/src/main/java/org/apache/rampart/builder/BindingBuilder.java
@@ -297,9 +297,6 @@ public abstract class BindingBuilder {
                 handler.handle(cb);
                 if(cb[0].getPassword() != null && 
!"".equals(cb[0].getPassword())) {
                     password = cb[0].getPassword();
-                    if (log.isDebugEnabled()) {
-                        log.debug("Password : " + password);
-                    }
                 } else {
                     //If there's no password then throw an exception
                     throw new RampartException("noPasswordForUser", 

Reply via email to