On Thu, Jan 6, 2011 at 10:55 AM, Ruwan Linton <[email protected]>wrote:
> I personally prefer to left this for the user to decide. I suppose we can > add 2 extensions on the same directory for the same deployer with 2 deployer > entries in the axis2.xml. In general being intelligent in the code is not > good while there is a configuration, because user assumes it to behave > according to the configuration. :-) > > So I think we should remove this .jar support, how ever why do we decide if > this is a service by looking at the extension?? To me this whole method and > usage if it is ambiguous :-( > yes. we need to remove this. thanks, Amila. > > Ruwan > > > On Thu, Jan 6, 2011 at 10:48 AM, Isuru Suriarachchi <[email protected]>wrote: > >> Hi all, >> >> In the current Axis2 trunk, even if I rename a .aar file in the >> repository/services folder to .jar, it is getting deployed as a .aar file. >> This happens because of the following code in the DeploymentFileData class. >> >> public static boolean isServiceArchiveFile(String filename) { >> return ((filename.endsWith(".jar")) | >> (filename.endsWith(".aar"))); >> } >> >> So do we need to support .jar files as well? I can remember that we >> supported JAX-WS services also in the "repository/services" folder before it >> was moved into "servicejars". Is this code something left from that >> implementation or is this intensional? Shouldn't we remove the support for >> .jar extension? >> >> WDYT? >> >> Thanks, >> ~Isuru >> >> -- >> Technical Lead, >> WSO2 Inc. http://wso2.org/ >> Blog : http://isurues.wordpress.com/ >> > > > > -- > Ruwan Linton > Software Architect & Product Manager > > WSO2 Inc.; http://wso2.org > > Lean . Enterprise . Middleware > > phone: +1 408 754 7388 ext 51789 > email: [email protected]; cell: +94 77 341 3097 > blog: http://blog.ruwan.org > linkedin: http://www.linkedin.com/in/ruwanlinton > google: http://www.google.com/profiles/ruwan.linton > tweet: http://twitter.com/ruwanlinton > -- Amila Suriarachchi WSO2 Inc. blog: http://amilachinthaka.blogspot.com/
