[ 
https://issues.apache.org/jira/browse/AXIS2-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983516#action_12983516
 ] 

Amila Chinthaka Suriarachchi commented on AXIS2-4921:
-----------------------------------------------------

this patch has the following code which is wrong

+            if(!wsdl4jOperation.getInput().equals(null)){
+                
addMessageDocumentation(axisOperation,wsdl4jOperation.getInput().getDocumentationElement(),
 WSDLConstants.MESSAGE_LABEL_IN_VALUE);
+            }
+            if(!wsdl4jOperation.getOutput().equals(null)){
+                
addMessageDocumentation(axisOperation,wsdl4jOperation.getOutput().getDocumentationElement(),
 WSDLConstants.MESSAGE_LABEL_OUT_VALUE);
+            }

you need to check for null like this,

if(wsdl4jOperation.getInput() != null){
                
addMessageDocumentation(axisOperation,wsdl4jOperation.getInput().getDocumentationElement(),
 WSDLConstants.MESSAGE_LABEL_IN_VALUE);
            }
            if(wsdl4jOperation.getOutput() != null){
                
addMessageDocumentation(axisOperation,wsdl4jOperation.getOutput().getDocumentationElement(),
 WSDLConstants.MESSAGE_LABEL_OUT_VALUE);
            }

please re attach the patch. And also attach a wsdl to test your feature.

For all the patches please run all the axis2 tests before you submit.

> Javadoc generation improvements for WSDL2JAVA code generation
> -------------------------------------------------------------
>
>                 Key: AXIS2-4921
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4921
>             Project: Axis2
>          Issue Type: Improvement
>          Components: codegen
>            Reporter: Supun Malinga
>            Assignee: Amila Chinthaka Suriarachchi
>            Priority: Minor
>         Attachments: patch_codegen.txt
>
>
> Currently in axis2 WSDL2JAVA code generation, generation of java doc is 
> incomplete. This issue is raised to monitor and fix those. Here is the 
> improvement scenario, 
> 1) add the '@return' parameter to the java doc 
> 2) add user specific comments for each '@param', '@return', '@throws' 
> parameters, using the given documentation in the wsdl.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to