[
https://issues.apache.org/jira/browse/AXIS2-4881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986240#action_12986240
]
Ruwan Linton commented on AXIS2-4881:
-------------------------------------
Folks, what is the wordict on this? To me this change is not required and
complicates the things, it even complicates the API, I too -1 on this change.
1. the implementer of the AbstractHandler has to anyway implement the invoke
method and there you decide to call invoke_stage1 and stage2, so to me this
really doesn't need to be exposed at the AbstractHandler level.
2. Further the names doesn't go with the normal coding standards where we do
not use '_' in method names.
3. These method names has no meaning.
I guess we need to revert this change, this is a must fix for the 1.6 release.
> Added invoke_stage1 and invoke_stage2 methods to AbstractHandler
> ----------------------------------------------------------------
>
> Key: AXIS2-4881
> URL: https://issues.apache.org/jira/browse/AXIS2-4881
> Project: Axis2
> Issue Type: Bug
> Reporter: Rich Scheuerle
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Background:
> The AbstractHandler class exposes an invoke() method that Handlers override
> to provide the specific invoke code.
> Problem:
> Many Handlers actually have 2 stages of logic. The first stage simply does
> some quick processing to determine if the handler should be called. The
> second stage does the actual work.
> Because there is only one invoke method, these separate stages of processing
> get lumped together.
> Solution:
> Provide an alternative (optional) invoke semantic.
> A Handler can choose to override the new invoke_stage1 and invoke_stage2
> methods.
> All current Handlers will continue to work. The existing invoke() method is
> retained.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
