[
https://issues.apache.org/jira/browse/RAMPART-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996761#comment-12996761
]
Andreas Veithen commented on RAMPART-321:
-----------------------------------------
-1 for these changes. Reasons:
* There is no point in doing a isXxxEnabled check if the log statement uses a
constant message. This is only needed if the message to be logged needs to be
calculated first.
* Using "private static boolean doDebug = log.isDebugEnabled();" is very bad
because it is no longer possible to change the log levels at runtime. There are
indeed some logging implementations (such as log4j or WebSphere's logging
subsystem) that allow to do this.
> Possible improvements to the logging in Rampart
> -----------------------------------------------
>
> Key: RAMPART-321
> URL: https://issues.apache.org/jira/browse/RAMPART-321
> Project: Rampart
> Issue Type: Improvement
> Reporter: Thilina Buddhika
> Assignee: Thilina Buddhika
> Fix For: 1.6.0
>
>
> In most of the places, debug level logs are used without checking the log
> level. Also there are some info level log messages which should be moved to
> the debug level.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
