[ 
https://issues.apache.org/jira/browse/TRANSPORTS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hiranya Jayathilaka updated TRANSPORTS-1:
-----------------------------------------

    Attachment: TRANSPORTS-1-update1.patch

Making a minor improvement to my earlier patch:

1. Fixing an issue with request-response handling scenarios (regression 
detected by JMS test suite)
2. Renaming an inaccurately named private method

With this all the existing tests pass

> JMSSender executes unnecessary JNDI lookups
> -------------------------------------------
>
>                 Key: TRANSPORTS-1
>                 URL: https://issues.apache.org/jira/browse/TRANSPORTS-1
>             Project: Axis2 Transports
>          Issue Type: Bug
>          Components: JMS
>            Reporter: Andreas Veithen
>            Priority: Minor
>             Fix For: 1.1.0
>
>         Attachments: TRANSPORTS-1-update1.patch, TRANSPORTS-1.patch
>
>
> JMSSender contains the following code:
> jmsOut = new JMSOutTransportInfo(targetAddress);
> // do we have a definition for a connection factory to use for this address?
> jmsConnectionFactory = getJMSConnectionFactory(jmsOut);     
> if (jmsConnectionFactory != null) {
>     messageSender = new JMSMessageSender(jmsConnectionFactory, targetAddress);
> } else {
>     ...
> }
> The constructor of JMSOutTransportInfo will create a new InitialContext and 
> lookup the destination from JNDI. If a connection factory definition is found 
> (jmsConnectionFactory != null), this is unnecessary because the 
> JMSMessageSender constructor will also create a new InitialContext (or reuse 
> a cached one) and carry out the JNDI lookup again.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to