[
https://issues.apache.org/jira/browse/AXIS2-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shameera Rathnayaka updated AXIS2-3933:
---------------------------------------
Attachment: AXIS2-3933.patch
Hi all ,
For a better architecture, kernel shouldn't have any dependency for transport
specific library,
I was able to remove httpclient 3.1 dependency from kernel pom with some
modifications. Then i ran the full build of axis2 with tests it did build
successfully.
I have attached patch file with this. Oleg had removed to some extent so i
referred his patch and did rest of the modifications to decouple kernel and
httpclient.
But there is one thing to point out,
1. kernel has a class called SSLProtocolSocketFactory which implements
org.apache.commons.httpclient.protocol.SecureProtocolSocketFactory but
there is no any usage of this class. In TrustAllTrustManager, this class is
used in a comment. As it seems this is a duplicate of org.apache.commons.
httpclient.protocol.SSLProtocolSocketFactory class, i have only removed the
interface implementation from this SSLProtocolSocketFactory class
which has a direct dependency for httpclient3.1 , But i think it would be ok
even if we remove this class.
Please review and commit.
> Axis2 kernel currently has a direct dependency on Commons HttpClient 3.1
> ------------------------------------------------------------------------
>
> Key: AXIS2-3933
> URL: https://issues.apache.org/jira/browse/AXIS2-3933
> Project: Axis2
> Issue Type: Wish
> Components: kernel
> Affects Versions: nightly
> Reporter: Oleg Kalnichevski
> Assignee: Andreas Veithen
> Attachments: AXIS2-3933.patch, axis2-kernel.patch
>
>
> (1) This seems conceptually wrong to me. The kernel ought not have any
> dependencies on a transport specific libraries
> (2) A more practical reason: it is just a matter of time HttpClient 3.1 will
> be superceded by HttpClient 4.0 and support for commons HttpClient will be
> discontinued.
> If there is an agreement this is indeed an issue, which should be resolved, I
> will happily invest time looking into what it takes to decouple HttpClient
> from Axis2 kernel.
> Oleg
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
