[ 
https://issues.apache.org/jira/browse/AXIS2-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Veithen reopened AXIS2-4413:
------------------------------------

      Assignee: Andreas Veithen

AXIOM-420 proposes a mechanism that is conceptually similar to the 
MTOMAwareOMBuilder thing, but that is better integrated into Axiom and that 
avoids building the OM tree twice. It will still (obviously) expand the entire 
tree in a single step, but after looking at some generated code, I think that 
it may actually be more performant than the getPullParser stuff. Anyways, in 
the Rampart scenario it is likely that the sourced element is entirely expanded.

Another thing to consider is that sometimes people complain about the volume of 
code generated by ADB, and the getPullParser code contributes to this, even if 
that code is broken and never used.

To summarize: the getPullParser stuff is
- broken (and will never be fixed),
- not used,
- unnecessarily increases the volume of generated code
- and is no longer relevant from a performance point of view.

Therefore the code should be removed entirely (which is why I'm reopening the 
issue).
                
> getPullParser methods generated by ADB are broken
> -------------------------------------------------
>
>                 Key: AXIS2-4413
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4413
>             Project: Axis2
>          Issue Type: Bug
>          Components: adb
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>
> When working on the ADB test suite, I noticed that the getPullParser methods 
> generated by ADB don't work properly. 98 (!) out of 114 existing test cases 
> (working properly with serialize or getOMElement) fail when trying to use 
> getPullParser.
> Probably this is the reason why ADBDataSource#getReader builds an Axiom tree 
> from the bean and gets the XMLStreamReader from this tree (which is highly 
> inefficient) instead of using getPullParser.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to