[ 
https://issues.apache.org/jira/browse/AXIS2-5340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293083#comment-13293083
 ] 

Hudson commented on AXIS2-5340:
-------------------------------

Integrated in Axis2 #1556 (See [https://builds.apache.org/job/Axis2/1556/])
    AXIS2-5340 - implemented proposed solution. (Revision 1348899)

     Result = SUCCESS
sagara : 
Files : 
* /axis/axis2/java/core/trunk/modules/integration/conf/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/integration/test-resources/SwA-enabled-axis2.xml
* 
/axis/axis2/java/core/trunk/modules/integration/test-resources/SwA-fileCache-enabled-axis2.xml
* 
/axis/axis2/java/core/trunk/modules/integration/test-resources/deployment/deployment.both.axis2.xml
* 
/axis/axis2/java/core/trunk/modules/integration/test-resources/jaxrs/pojo-enabled-axis2.xml
* 
/axis/axis2/java/core/trunk/modules/integration/test-resources/mtom/MTOM-enabled-axis2.xml
* 
/axis/axis2/java/core/trunk/modules/integration/test-resources/mtom/MTOM-fileCache-enabled-axis2.xml
* 
/axis/axis2/java/core/trunk/modules/integration/test-resources/swa/SwA-enabled-axis2.xml
* 
/axis/axis2/java/core/trunk/modules/integration/test-resources/swa/SwA-fileCache-enabled-axis2.xml
* 
/axis/axis2/java/core/trunk/modules/integration/test/org/apache/axis2/engine/chunking-disabled-axis2.xml
* 
/axis/axis2/java/core/trunk/modules/integration/test/org/apache/axis2/engine/chunking-enabled-axis2.xml
* 
/axis/axis2/java/core/trunk/modules/integration/test/org/apache/axis2/engine/commons-http-enabled-axis2.xml
* /axis/axis2/java/core/trunk/modules/jaxws-integration/test-resources/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/jaxws-integration/test-resources/axis2_addressing.xml
* /axis/axis2/java/core/trunk/modules/jibx/src/test/repo/conf/axis2.xml
* /axis/axis2/java/core/trunk/modules/json/test-resources/axis2.xml
* /axis/axis2/java/core/trunk/modules/kernel/conf/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/DeploymentEngine.java
* 
/axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/axis2_default.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/repository/util/DeploymentFileData.java
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/AxisMessageTestRepo/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/BadConfigOrderChange/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/ConfigWithObservers/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/CustomDeployerRepo/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/ParaLockedRepo/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/SystemPhaseRemove/axis2.xml
* /axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/axis2_a.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/builderSelectorTest/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/exculeRepo/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/exposedTransportsRepo/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/faultyServiceshandling/repo/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/hierarchicalServiceRepo/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/hostConfigrepo/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/messageFormatterTest/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/moduleConfig/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/moduleDisEngegeRepo/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/moduleVersion/Test1/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/repositories/moduleLoadTest/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/serviceGroupRepo/axis2.xml
* 
/axis/axis2/java/core/trunk/modules/kernel/test-resources/deployment/soaproleconfiguration/axis2.xml
* /axis/axis2/java/core/trunk/modules/webapp/conf/axis2.xml

                
>  ServiceDeployer should follow the standard deployment architecture
> -------------------------------------------------------------------
>
>                 Key: AXIS2-5340
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5340
>             Project: Axis2
>          Issue Type: Improvement
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> Axis2 ServiceDeployer implements Deployer interface like any other Axis2 
> deployers but it does not use axis2.xml file instead ServiceDeployer is hard 
> coded in DeploymentEngine. This approach having some limitations. 
> 1.) It is not possible to disable ServiceDeployer if a user only wants to use 
> any other deployer. ( e.g - only JAX-WS deployer) but other deployers grant 
> such features. 
> 2.) It is not possible to use  newly introduced custom 
> ServiceBuilderExtension  feature with ServiceDeployer. 
> 3.) Standard  axis2.xml based <deployer> element use "extension" and 
> "directory" attributes to define deployment unit type ( file extension) and 
> container directory. But ServiceDeployer only work with AAR or exploded AAR 
> archives also use "ServicesDirectory" parameter to specify directory this is 
> no longer required with proposed solution.   
>  
> 4.) It's kind of bad practice to have two deployment architectures within a 
> single framework. It would be nice to port ServiceDeployer into well designed 
> Deployer interface + axis2.xml based approach. 
>  
> 5.) With above 3. it is possible to use customized ServiceDeployers easily. 
> Following entry need to be added to axis2.xml files of existing applications 
> to keep backward comparability if the applications upgraded to Axis2 1.7.0 or 
> later versions. 
>   <deployer extension=".aar" directory="services" 
> class="org.apache.axis2.deployment.ServiceDeployer">
>         <serviceBuilderExtension name ="jwsbuilderExt" 
> class="org.apache.axis2.jaxws.framework.JAXWSServiceBuilderExtension"/>
>         <serviceBuilderExtension name ="jwsbuilderExt" 
> class="org.apache.axis2.deployment.WSDLServiceBuilderExtension"/>
>    </deployer>     

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to