[ https://issues.apache.org/jira/browse/AXIS2-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497172#comment-13497172 ]
Hudson commented on AXIS2-5300: ------------------------------- Integrated in axis2-1.6 #322 (See [https://builds.apache.org/job/axis2-1.6/322/]) Merged a couple of fixes to the 1.6 branch to avoid 100% CPU usage triggered by certain JSON payloads: * AXIS2-5044 (r1127327; prerequisite for the other fixes) * AXIS2-5125 (r1243469, r1290999) * AXIS2-5300 (r1332362, r1332402; requires Axiom 1.2.14) (Revision 1409218) Result = SUCCESS veithen : Files : * /axis/axis2/java/core/branches/1_6 * /axis/axis2/java/core/branches/1_6/modules/json/src/org/apache/axis2/json/AbstractJSONDataSource.java * /axis/axis2/java/core/branches/1_6/modules/json/src/org/apache/axis2/json/AbstractJSONMessageFormatter.java * /axis/axis2/java/core/branches/1_6/modules/json/src/org/apache/axis2/json/AbstractJSONOMBuilder.java * /axis/axis2/java/core/branches/1_6/modules/json/src/org/apache/axis2/json/JSONBadgerfishDataSource.java * /axis/axis2/java/core/branches/1_6/modules/json/src/org/apache/axis2/json/JSONBadgerfishMessageFormatter.java * /axis/axis2/java/core/branches/1_6/modules/json/src/org/apache/axis2/json/JSONBadgerfishOMBuilder.java * /axis/axis2/java/core/branches/1_6/modules/json/src/org/apache/axis2/json/JSONDataSource.java * /axis/axis2/java/core/branches/1_6/modules/json/src/org/apache/axis2/json/JSONMessageFormatter.java * /axis/axis2/java/core/branches/1_6/modules/json/src/org/apache/axis2/json/JSONOMBuilder.java * /axis/axis2/java/core/branches/1_6/modules/json/test/org/apache/axis2/json/JSONDataSourceTest.java * /axis/axis2/java/core/branches/1_6/modules/json/test/org/apache/axis2/json/JSONOMBuilderTest.java * /axis/axis2/java/core/branches/1_6/modules/parent/pom.xml * /axis/axis2/java/core/branches/1_6/modules/saaj > org.apache.axis2.json.AbstractJSONOMBuilder hangs when JSON has wrong format > ---------------------------------------------------------------------------- > > Key: AXIS2-5300 > URL: https://issues.apache.org/jira/browse/AXIS2-5300 > Project: Axis2 > Issue Type: Bug > Components: json > Affects Versions: 1.6.2 > Environment: Apache tomcat 7.0.25 > Ubuntu 64Bit 11.10 > Reporter: Matthias Gerber > Assignee: Andreas Veithen > Fix For: 1.7.0 > > > org.apache.axis2.json.AbstractJSONOMBuilder hangs when JSON has wrong format: > Code loping through reader at line 119 and 135 to get localName should check > for end of stream. > Otherwise the code cycles for ever if the string to parse does not contain a > ":" > Code as it is at the moment: > 118 char temp = (char)reader.read(); > 119 while (temp != ':') { > 120 if (temp != ' ' && temp != '{' && temp != '\n' && temp != > '\r' && temp != '\t') { > 121 localName += temp; > 122 } > 123 temp = (char)reader.read(); > 124 } > Code as it should be (or something like that): > int t = reader.read(); > 118 char temp = (char)t; > 119 while (temp != ':' && t >= 0) { > 120 if (temp != ' ' && temp != '{' && temp != '\n' && temp != > '\r' && temp != '\t') { > 121 localName += temp; > 122 } > t = reader.read(); > 123 temp = (char)t; > 124 } > And maybe some error handling if end of stream is reached. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@axis.apache.org For additional commands, e-mail: java-dev-h...@axis.apache.org