Yes, it is not a good idea to make changes which violate the Axis2 basic principals for the sake of user friendly messages.Actually I did above changes based on Specifications. But we need to address architectural issues when supporting the specifications. Thanks all for guiding me to the right direction.
I have reverted the commit and moved changes to MessageReceiver level. New changes committed to the trunk and merged to 1.6.3 as well. I think it would be good to add these changes to ADB generated MessageRecievers too. Will work on that. Thanks, Shameera. On Mon, May 6, 2013 at 12:50 PM, Sagara Gunathunga < [email protected]> wrote: > > > On Sun, May 5, 2013 at 8:52 PM, Deepal jayasinghe <[email protected]>wrote: > >> On 5/5/2013 11:16 AM, Shameera Rathnayaka wrote: >> >> >> >> >> On Sun, May 5, 2013 at 8:32 PM, Deepal jayasinghe <[email protected]>wrote: >> >>> Good point, if that is the cases then it violates the whole point of >>> deferred building. Because we prefer to build the full message only at >>> the MessageReceiver. >>> >>> At which point does this get called ? >>> >> >> Soon after builder build the document. and >> before AxisEngine.receive(...) get called. >> >> If you do that, then we are going back to 'Axis1', one of the major >> design decisions of Axis2 was to build the SOAP message when absolutely >> necessary. For example build it at MR level. For that reason, I am sorry >> but I have to -1 this commit. >> > > > If you investigate Axis2 JAX-WS performance issues one problem caused is > it violated "deferred building" principle in several places and now it's > hard to change the design. Providing user friendly messages is a good > features but we can't loose our fundamental design principal for that I > also think there should be a better way to improve error messages than > early building message hence I also -1 for above commit. > > Thanks ! > >> >> Deepal >> > > > > -- > Sagara Gunathunga > > Blog - http://ssagara.blogspot.com > Web - http://people.apache.org/~sagara/ > LinkedIn - http://www.linkedin.com/in/ssagara -- Best Regards, Shameera Rathnayaka. email: shameera AT apache.org , shameerainfo AT gmail.com Blog : http://shameerarathnayaka.blogspot.com/
