[
https://issues.apache.org/jira/browse/AXIS2-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934317#comment-13934317
]
Hudson commented on AXIS2-3710:
-------------------------------
SUCCESS: Integrated in Axis2 #2565 (See
[https://builds.apache.org/job/Axis2/2565/])
Removed the hack for AXIS2-3710. It is reasonable to require code running with
a new major Axis2 release to conform to the Java EE specs (i.e. to override the
GenericServlet#init(ServletConfig) method in a correct way). (veithen: rev
1577346)
*
/axis/axis2/java/core/trunk/modules/transport/http/src/org/apache/axis2/transport/http/AxisServlet.java
Correctly override the AxisServlet init method to avoid the issue described in
AXIS2-3710. (veithen: rev 1577345)
*
/axis/axis2/java/core/trunk/modules/osgi/src/org/apache/axis2/osgi/OSGiAxisServlet.java
> fixes for backward compatibility
> ---------------------------------
>
> Key: AXIS2-3710
> URL: https://issues.apache.org/jira/browse/AXIS2-3710
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.4
> Environment: Any
> Reporter: Saminda Wishwajith Abeyruwan
> Assignee: Davanum Srinivas
> Priority: Blocker
> Fix For: 1.4
>
> Attachments: axisservlet.patch
>
>
> Hi,
> Is there a particular reason to add the line.
> msgContext.setProperty(HTTPCon
> stants.MC_HTTP_SERVLETCONTEXT, getServletContext());
> You will be able to access the context from http servlet request object.
> Beside the prior added line will break some of the existing production code.
> getServletContext() will work properly, IFF the user's servlet inherit the
> init method or if over-rides, it should called the parent init method.
> In AxisServlet, yes it dose over-rides the init method and calls the parent
> init.
> But those of us who have extended AxisServlet to work with, where over-rides
> the init method to intialize the AxisConfiguration the way our production
> system wants does not call the parents (AxisServlet) init method.
> ex:
> public class MyServlet extends AxisServlet {
> ...
> public void init(ServletConfig config) {
> // my way of initializing axisconfiguration and listeners rather using
> parent
> // init, but inheriting parents do* from AxisServlet.
> }
> }
> We used AxisServlet as show above for quite a long time.
> I'm afraid the prior line of code has broken the backward compatibility of
> re-using AxisServlet in production environments.
> Thus, the correct way is to obtain the servlet context from request, rather
> setting the property.
> Thus, I would humbly ask to revert the commit to preserve backward
> compatibility.
> Thank you!
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
