[ https://issues.apache.org/jira/browse/AXIS2-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135788#comment-16135788 ]
Hudson commented on AXIS2-5868: ------------------------------- SUCCESS: Integrated in Jenkins build axis2-1.7 #132 (See [https://builds.apache.org/job/axis2-1.7/132/]) AXIS2-5868: Merge r1805563 to the 1.7 branch. (veithen: rev 1805667) * (edit) axis2 * (edit) axis2/modules/kernel/src/org/apache/axis2/description/ParameterIncludeImpl.java > Small logic error in axis2-kernel ParameterIncludeImpl.java > ----------------------------------------------------------- > > Key: AXIS2-5868 > URL: https://issues.apache.org/jira/browse/AXIS2-5868 > Project: Axis2 > Issue Type: Bug > Components: kernel > Affects Versions: 1.7.6 > Reporter: Jeff Thomas > Priority: Minor > > Found small bug in the axis2-kernel ParameterIncludeImpl.java. > The "parameters.put(param.getName(), param)" is always performed twice. > It looks like a copy/paste mistake when moving the "put" into the try block, > the original line was not removed and remains outside of the try block. In > the worst-case scenario, the ConcurrentModificationException would not be > caught as expected. > {code:java} > public void addParameter(Parameter param) { > if (param != null) { > synchronized (parameters) { > parameters.put(param.getName(), param); > try { > parameters.put(param.getName(), param); > } catch (ConcurrentModificationException cme) { > ... > } > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@axis.apache.org For additional commands, e-mail: java-dev-h...@axis.apache.org