[
https://issues.apache.org/jira/browse/AXIS2-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156704#comment-16156704
]
Thorsten Schöning commented on AXIS2-5881:
------------------------------------------
In my opinion this is a great enhancement, I'm searching within the browser
output for the service I need all the time as well. Looking at your changes, I
have two additional questions:
1. Is there a reason why you are using "ConcurrentSkipListMap" instead of a
simple "TreeMap"? The former sounds like one needs to keep concurrent access in
mind, but form my understanding that shouldn't be the case and both provide the
natural sorting we want.
2. While things get changed here anyway, might AxisService.getOperations() be
replaced with AxisService.getPublishedOperations()? Currently there doesn't
seem to be a distinction of both in the list, so one might wonder why some are
part of the linked WSDL and some are not.
{CODE}
// If we've set the "expose" parameter for this operation, it's
// normal (non-
// control) and therefore it will appear in generated WSDL. If
// we haven't,
// it's a control operation and will be ignored at WSDL-gen
// time.
if (axisOperation
.isParameterTrue(DeploymentConstants.TAG_EXPOSE)) {
axisOperation.setControlOperation(false);
} else {
axisOperation.setControlOperation(true);
}
{CODE}
> Small improvement to the listServices.jsp to sort services and operations
> -------------------------------------------------------------------------
>
> Key: AXIS2-5881
> URL: https://issues.apache.org/jira/browse/AXIS2-5881
> Project: Axis2
> Issue Type: Improvement
> Affects Versions: 1.7.3
> Reporter: Jeff Thomas
> Priority: Minor
> Attachments: listServices.jsp
>
>
> One thing that has always bothered me about the "services/listServices.jsp"
> was that it is not sorted ... which means scrolling around looking for the
> service and/or operations.
> In our build I have updated the listServices.jsp with a few changes to sort
> the output of services and operations... would just like to suggest the fix
> be incorporated in the build. (see attachment). Primarily I replaced the
> HashMaps with ConcurrentSkipListMap to naturally sort by the keys
> (ServiceName, OperationName)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
