[ 
https://issues.apache.org/jira/browse/AXIS2-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895888#comment-17895888
 ] 

Christian Ortlepp commented on AXIS2-6040:
------------------------------------------

I've started to look into this, but I'm not really sure how to do this 
correctly for Axis. For starters, do we only have to define the base module 
name (I have assumed "org.apache.axis2") somewhere in the parent, or does every 
module of ours (for example "org.apache.axis2.transport.base") need it's own 
automatic module? Staying with the example of 
"org.apache.axis2.transport.base", it contains some classes that are not in the 
transport.base package, namely "org.apache.axis2.format". As far as I 
understand it this is not allowed in the module system. Do we skip those 
modules and just decide to look into them later, do we move the classes to a 
separate module or is there another option?

There are multiple other similar modules that from first glance seem 
incompatible with properly modularizing axis2 (axis2-webapp, 
axis2-transport-testkit and probably more). Maybe someone who has more 
experience with the module system can take another look at this?

> Define Automatic-Module-Name for Java9 module system compatibility
> ------------------------------------------------------------------
>
>                 Key: AXIS2-6040
>                 URL: https://issues.apache.org/jira/browse/AXIS2-6040
>             Project: Axis2
>          Issue Type: Improvement
>          Components: kernel
>    Affects Versions: 1.8.2
>            Reporter: Wolfgang Knauf
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> After Java9 module system compatibility was fixed through 
> [https://issues.apache.org/jira/browse/AXIS2-4311], I used Eclipse to create 
> a "module-info.java" to my small sample project.
> This is the resulting module-info.java file:
> {{module myprojectname}}
> {{{}}
> {{  exports my.own.project.package;}}
> {{  requires axiom.api;}}
> {{  requires axis2.adb;}}
> {{  requires axis2.kernel;}}
> {{  requires commons.logging;}}
> {{  requires jakarta.activation;}}
> {{  requires java.rmi;}}
> {{  requires java.xml;}}
> {{}}}
>  
> This results in four eclipse warnings:
> {{Name of automatic module 'axiom.api' is unstable, it is derived from the 
> module's file name.}}
> {{Name of automatic module 'axis2.adb' is unstable, it is derived from the 
> module's file name.}}
> {{Name of automatic module 'axis2.kernel' is unstable, it is derived from the 
> module's file name.}}
> {{Name of automatic module 'commons.logging' is unstable, it is derived from 
> the module's file name.}}
> As far as I understand it, it would be sufficient to add a 
> "Automatic-Module-Name" entry to Manifest.mf for the Axis2 jars- see e.g. 
> [https://github.com/ReactiveX/RxJava/issues/5618]
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@axis.apache.org
For additional commands, e-mail: java-dev-h...@axis.apache.org

Reply via email to