cortlepp commented on PR #842: URL: https://github.com/apache/axis-axis2-java-core/pull/842#issuecomment-2697769029
> That last IP should be returned in the List from this new method as one of the IP's, correct? Well, yes, but actually no (I think). The current implementation was somewhat incorrect because it checked the site-local attribute for IPv6 which has been [deprecated](https://www.ietf.org/rfc/rfc3879.txt). Your address there is a [unique local address](https://en.wikipedia.org/wiki/Unique_local_address) which (if I understood the definition correctly) is also not something we want. In the revised implementation I am filtering these out, but because the standard library does not have this check implemented I had to do this myself. > Your code does return an ipv4 address as the first in the List. From what I understand of the code, the List should contain my ipv6 address from my router but probably the first entry should be ipv4 as the priority? I'm guessing the order of network interfaces is jvm/platform specific, the revised code returns an IPv6 address first on my machine. Not sure whether that is wise, or if we should prioritize (for backwards compatibility) IPv4 addresses. Maybe it would also be good to respect `java.net.preferIPv4Stack` and `java.net.preferIPv6Addresses`, or introduce an axis-specific option (if this is important). The revised implementation on my machine returns 3 IP addresses, one IPv4 and two IPv6 (and according to my router these addresses are also actually being used). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: java-dev-unsubscr...@axis.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@axis.apache.org For additional commands, e-mail: java-dev-h...@axis.apache.org
