Okay, thanks.
+1 from me too then :).
Christian
On 5/19/26 17:09, robertlazarski wrote:
External Message - Please be cautious when opening links or attachments
Christian,
Thankyouforthereview—botharevalidcatches,andI'vefixedthem:
1.certs/movedfromtherepositoryrootto
modules/samples/userguide/src/userguide/springbootdemo-tomcat11/certs/
wheretheybelong.AddedaREADMEmakingcleartheseare
development-only
(self-signedCA,password"changeit",CAprivatekeyispublic—zero
productionsecurity).Commit61699d8.
2.194buildartifacts(JARs,MARs,AARs,compiledclasses)removedfrom
springbootdemo-tomcat11/WEB-INF/.Thesewereaccidentallycommitted
mvninstalloutput.Added.gitignoretopreventrecurrence.Commit
a8f7997.
Neitherissueaffectsthereleaseartifacts—thedistributionZIPdoes
notincludethesamples'buildoutputorthecerts/directory.
+1frommestillstands.
Robert
On Mon, May 18, 2026 at 10:48 PM Christian Ortlepp
<[email protected]> wrote:
Hey,
I just had a look at the diff, unfortunately it's quite a lot
(even though large parts of it are just removals) so i couldn't
really review it in detail, but two things seemed a bit "funny" to me
1. You added a certs folder in the repository root, as far as I
can tell because you need some certificates for McpBridgeMainTest
. Is there a reason why you didn't put them in the test resources
of that module? I'm just a little worried that someone might use
those in production by accident (plus it seems a bit odd to me to
have them in the repository root if they are indeed just test
resources).
2. You commited a whole lot of classfiles/jars beneath
'modules/samples/userguide/src/userguide/springbootdemo-tomcat11/WEB-INF/modules',
was that intended?
Best,
Christian
On 5/18/26 13:52, robertlazarski wrote:
External Message - Please be cautious when opening links or
attachments
Git tag:
https://github.com/apache/axis-axis2-java-core/releases/tag/v2.0.1
Distributions:
https://dist.apache.org/repos/dist/release/axis/axis2/java/core/2.0.1/
Maven artifacts:
https://repository.apache.org/content/repositories/orgapacheaxis2-1028
Site: https://axis.apache.org/axis2/java/core-staging/
+1 from me
Robert
