Erik Hatcher wrote:
On Apr 26, 2005, at 2:38 PM, Daniel Naber wrote:
On Tuesday 26 April 2005 02:21, [EMAIL PROTECTED] wrote:
+ public String toString() { + try { + return getDocument().toString(); + } catch (IOException e) { + return null; + } + }
Wouldn't it be better here to re-throw the exception as a RuntimeException?
I don't know.... would it? I have no preference, though it seems ok to me to simply return null since this is the toString method. For a Document, the toString is only useful for debugging anyway.
Two thoughts:
If getDocument().toString() cannot possibly throw an IOException, but it is part of the signature, then it does not matter.
Once lucene is at 1.4, it would be better to use an assert in the catch and not throw an error but return "" instead of null. The asserts can be removed at runtime by passing flags to the program. Assertions are best used for situations that should never happen.
public String toString()
{
try {
return getDocument().toString();
} catch (IOException e) {
assert false : e;
return "";
}
}--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
