Martin - nevermind! I have implemented all of the necessary .rewrite methods for the SpanQuery subclasses that accept SpanQuery(s) in their constructors. I will commit these changes in the next day or so if there are no objections.

Thanks for mentioning that you had done this - it validated my approach.

    Erik


On Sep 15, 2005, at 6:39 AM, Erik Hatcher wrote:

Martin,

Would you care to submit your changes as a patch to Lucene itself? Unless there are any objections, I'd be happy to commit them. If for some reason you can't contribute it, then I'll create those methods myself - you're right, it won't be difficult, only a few lines of code should do it.

    Erik


On Sep 14, 2005, at 7:39 PM, Martin Haye wrote:


I had to make changes like this to get my own SpanRangeQuery and
SpanWildcardQuery to work properly in the larger context. Adding the rewrite
methods wasn't too hard.

--Martin

On 9/14/05, Erik Hatcher <[EMAIL PROTECTED]> wrote:



I'm implementing a custom SpanQuery subclass that expands into
multiple terms (sort of like WildcardQuery). I've subclassed
SpanQuery and overridden the rewrite method to rewrite itself into a
SpanOrQuery. This works fine by itself as a standalone query.

However, when my custom SpanQuery subclass is nested within a
SpanNearQuery it is not rewritten (as SpanQuery and all the built-in
subclasses) defer to Query.rewrite.

What are my options in this regard?

Should the Span*Query's that aggregate other SpanQuery's
(SpanOrQuery, SpanNearQuery) do something like BooleanQuery.rewrite
()? It seems like it should just to be on the safe side and allow
rewriting SpanQuery's.

Thoughts?

Thanks,
Erik





-------------------------------------------------------------------- -
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]







---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to