Erik Hatcher wrote:
As for accepting patches - with Lucene I'm personally very conservative with applying patches.

There are good reasons to be conservative. When a committer commits a patch he or she vouches for the quality of that patch. Any problems that ensue are, to some degree, the responsibility of that committer.

When constructing a patch one should make it easy for a committer to apply. At a minimum it should apply easily to trunk and pass all unit tests. It should confine itself to a single issue: changing as little as possible; adding as little as possible. The case is stronger if others report to have successfully applied the patch and found it useful.

If one feels a patch is neglected one should be persistent, polite and patient.

Doug

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to