[ http://issues.apache.org/jira/browse/LUCENE-475?page=comments#action_12359170 ]
Yonik Seeley commented on LUCENE-475: ------------------------------------- super minor nit: toRead = Math.min(len-readCount, BufferedIndexOutput.BUFFER_SIZE) is easier on my eyes than + int toRead = readCount + BufferedIndexOutput.BUFFER_SIZE > len ? len - readCount : BufferedIndexOutput.BUFFER_SIZE; > RAMDirectory(Directory dir, boolean closeDir) constructor uses memory > inefficiently. > -------------------------------------------------------------------------------------- > > Key: LUCENE-475 > URL: http://issues.apache.org/jira/browse/LUCENE-475 > Project: Lucene - Java > Type: Improvement > Components: Store > Reporter: Volodymyr Bychkoviak > Attachments: RamDirectory.diff, RamDirectory2.diff > > recently I found that RAMDirectory(Directory dir, boolean closeDir) > constructor uses memory inefficiently. > files from source index are read entirely intro memory as single byte array > which is after all is thrown away. And if I want to load my 200M optimized, > compound format index to memory for faster search I should give JVM at least > 400Mb memory limit. For larger indexes this can be an issue. > I've attached patch how to solve this problem. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
