[ 
http://issues.apache.org/jira/browse/LUCENE-507?page=comments#action_12369262 ] 

Doug Cutting commented on LUCENE-507:
-------------------------------------

I don't see the point in patching code that's automatically generated by 
JavaCC.  It will just get overwritten the next time someone changes the 
grammer, no?

Also, GCJ-related changes are best verified.  Andi?

> CLONE -[PATCH] remove unused variables
> --------------------------------------
>
>          Key: LUCENE-507
>          URL: http://issues.apache.org/jira/browse/LUCENE-507
>      Project: Lucene - Java
>         Type: Improvement
>   Components: Search
>     Versions: unspecified
>  Environment: Operating System: other
> Platform: Other
>     Reporter: Steven Tamm
>     Assignee: Lucene Developers
>     Priority: Minor
>  Attachments: Unused.patch
>
> Seems I'm the only person who has the "unused variable" warning turned on in 
> Eclipse :-) This patch removes those unused variables and imports (for now 
> only in the "search" package). This doesn't introduce changes in 
> functionality, but it should be reviewed anyway: there might be cases where 
> the variables *should* be used, but they are not because of a bug.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to