[ http://issues.apache.org/jira/browse/LUCENE-621?page=all ]
     
Hoss Man resolved LUCENE-621:
-----------------------------

    Resolution: Fixed

patches applied cleanly with no obvious downsides that I could think of.

commited with some minor javadoc tweaks (added missing "@see" declaration to 
some javadoc lines in the patch, and aded some new @see declarations to the 
existing static variables pointing at the new setters)

> Default lock timeouts should have static setter/getters
> -------------------------------------------------------
>
>          Key: LUCENE-621
>          URL: http://issues.apache.org/jira/browse/LUCENE-621
>      Project: Lucene - Java
>         Type: Bug

>   Components: Index
>     Versions: 2.0.0
>     Reporter: Michael McCandless
>     Priority: Minor
>  Attachments: IndexWriter.java.diff, TestIndexWriter.java.diff
>
> We recently stopped using Java system properties to derive defaults for 
> things like the write/commit lock timeout, and switched to getter/setter's 
> across all classes.  See here:
>     http://www.gossamer-threads.com/lists/lucene/java-dev/27447
> But, in the case at least of the write lock timeout, because it's marked 
> "public final static", a consumer of this API can no longer change this value 
> before instantiating the IndexWriter.  This is because the getter/setter for 
> this is not static, which generally makes sense so you can change the timeout 
> for each instance of IndexWriter.  But because IndexWriter on construction 
> uses the timeout value, some uses cases need to change the value before 
> getting an instance of IndexWriter.
> This was actually a regression, in that Lucene users lost functionality they 
> previously had, on upgrading.
> I would propose that that we add getter/setter for the default value of this 
> timeout, which would be static.  I'll attach a patch file.
> See this thread for context that led to this issue:
>    http://www.gossamer-threads.com/lists/lucene/java-dev/37421

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to