Hi Chuck, I think bulk update would be good (although I'm not sure how it would be different from batching deletes and adds, but I'm sure there is a difference, or else you wouldn't have done it). Java 1.5 - no conclusion, but personally I felt: - no strong arguments for 1.4, only a few people argued for it - very little interest from 1.4 adversaries in helping with backporting to 1.4 or updating the build system to do the retro thing with 1.5 code
So I think you should contribute your code. This will give us a real example of having something possibly valuable, and written with 1.5 features, so we can finalize 1.4 vs. 1.5 discussion, probably with a vote on lucene-dev. Otis ----- Original Message ---- From: Chuck Williams <[EMAIL PROTECTED]> To: java-dev@lucene.apache.org Sent: Thursday, July 6, 2006 5:07:41 PM Subject: Re: [jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided) robert engels wrote on 07/06/2006 12:24 PM: > I guess we just chose a much simpler way to do this... > > Even with you code changes, to see the modification made using the > IndexWriter, it must be closed, and a new IndexReader opened. > > So a far simpler way is to get the collection of updates first, then > > using opened indexreader, > for each doc in collection > delete document using "key" > endfor > > open indexwriter > for each doc in collection > add document > endfor > > open indexreader > > > I don't see how your way is any faster. You must always flush to disk > and open the indexreader to see the changes. .... Bulk updates however require yet another approach. Sorry to change topics here, but I'm wondering if there was a final decision on the question of java 1.5 in the core. If I submitted a bulk update capability that required java 1.5, would it be eligible for inclusion in the core or not? Chuck --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
