[ http://issues.apache.org/jira/browse/LUCENE-639?page=comments#action_12424038 ] Nicolas Lalevée commented on LUCENE-639: ----------------------------------------
The loop you unrolled has no compilation-time known iteration. A VInt is not a limited length type. Your patch only works if you don't use Vint larger than 268,435,456. > [PATCH] Slight performance improvement for readVInt() of IndexInput > ------------------------------------------------------------------- > > Key: LUCENE-639 > URL: http://issues.apache.org/jira/browse/LUCENE-639 > Project: Lucene - Java > Issue Type: Improvement > Components: Index > Affects Versions: 2.0.0 > Reporter: Johan Stuyts > Priority: Minor > Attachments: Lucene2ReadVIntPerformance.patch > > > By unrolling the loop in readVInt() I was able to get a slight, about 1.8 %, > performance improvement for this method. The test program invoked the method > over 17 million times on each run. > I ran the performance tests on: > - Windows XP Pro SP2 > - Sun JDK 1.5.0_07 > - YourKit 5.5.4 > - Lucene trunk -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
