[ http://issues.apache.org/jira/browse/LUCENE-667?page=comments#action_12443864 ] Yonik Seeley commented on LUCENE-667: -------------------------------------
The removed deprecations were part of the lucene-wide sweep to remove all deprecated methods going from Lucene 1.9 to 2.0.... it wasn't necessary in the case of SimpleCharStream. I'm fine with this patch. > javacc skeleton files not regenerated > ------------------------------------- > > Key: LUCENE-667 > URL: http://issues.apache.org/jira/browse/LUCENE-667 > Project: Lucene - Java > Issue Type: Bug > Components: QueryParser > Reporter: Steven Parkes > Assigned To: Steven Parkes > Priority: Minor > Fix For: 2.1 > > Attachments: javacc.patch > > > Copies of the the character stream files for javacc are checked into svn. > These files were generated under javacc 3.0 (at least that's what they say, > though javacc 3.2 says this too). javacc 4 complains that they are out of > date but won't replace them; they must be removed before it will regenerate > them. > There is one side effect of removing them: local changes are lost. r387550 > removed a couple of deprecated methods. By using the files as generated by > javacc, these deprecated methods will be readded (at least until the javacc > team removes them totally). There are other changes being made to the stream > files, so I woudl think it's better to live with them unmodified than to keep > local versions just for this change. > If we want javacc to recreate the files, the attached patch will remove them > before running javacc. > All the tests pass using both javacc3.2 and 4.0. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
