: I was in the middle of updating it. Ah ..... i *really* don't think we should ever replace one patch with another ... it makes it impossible to compare the pros/cons of the two approaches.
: -----Original Message----- : From: Chris Hostetter [mailto:[EMAIL PROTECTED] : Sent: Wednesday, October 25, 2006 11:10 AM : To: java-dev@lucene.apache.org : Subject: Re: [jira] Commented: (LUCENE-657) FuzzyQuery should not be : final : : : what happend to the patch for this issue? ... there doesn't seem to be : anything attached to it in Jira. : : : : Date: Wed, 25 Oct 2006 11:02:28 -0700 : : From: Andreas Neumann <[EMAIL PROTECTED]> : : Reply-To: java-dev@lucene.apache.org : : To: java-dev@lucene.apache.org : : Subject: Re: [jira] Commented: (LUCENE-657) FuzzyQuery should not be : final : : : : Two comments: : : : : 1. In this particular case, all I need is the ability to override base : : class method : : getEnum(). No need to access or change member variables. As the : class already : : defines getters for the members, the members can remain private. : : : : 2. I noticed that many members have package (default Java) visibility. : : An example is : : analysis.Token. Its two members startOffset and endOffset only have : : getters, but no : : setters. If you want to set these after the Token was constructed, : : you need to define : : a subclass in the org.apache.lucene.analysis package. In cases like : : this, I don't think : : it would harm to make them protected, such that subclasses outside : : the package : : can access them. Or add setters to the base class. : : : : - Andreas. : : : : --------------------------------------------------------------------- : : To unsubscribe, e-mail: [EMAIL PROTECTED] : : For additional commands, e-mail: [EMAIL PROTECTED] : : : : : : -Hoss : : : --------------------------------------------------------------------- : To unsubscribe, e-mail: [EMAIL PROTECTED] : For additional commands, e-mail: [EMAIL PROTECTED] : : : --------------------------------------------------------------------- : To unsubscribe, e-mail: [EMAIL PROTECTED] : For additional commands, e-mail: [EMAIL PROTECTED] : -Hoss --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
