"Michael McCandless (JIRA)" <[EMAIL PROTECTED]> wrote on 09/01/2007 03:32:27:
> > I think however that the test Mike added does not expose the docs > > out of order bug - I tried this test without the fix and it only > > fail on the "gotException assert" - if you comment this assert the > > test pass. > > Huh, I see my test case (in IndexReader) indeed hitting the original > "docs out of order" exception. If I take the current trunk and > comment out the (one line) bounds check in BitVector.set and run that > test, it hits the "docs out of order" exception. > > Are you sure you updated the change (to tighten the check to a <= from > a <) to index/SegmentMerger.java? Because, I did indeed find that the > test failed to fail when I first wrote it (but should have). So in > digging why it didn't fail as expected, I found that the check for > "docs out of order" missed the boundary case of the same doc number > twice in a row. Once I fixed that, the test failed as expected. > That's a moving target...:-) You're right, I ran without the SegmentMerger-tightened-check, imitating current 1.9.1 "field experience". --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
