[
https://issues.apache.org/jira/browse/LUCENE-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464676
]
Hoss Man commented on LUCENE-550:
---------------------------------
I've been trying to follow the work you've been doing Karl, but i must admit a
lot of it is over my head -- but since i've got a long weekend and your patch
now makes so few changes to the core i could acctually make sense of that part,
so here are some comments on those changes...
1) some of these changes seem to be duplicated in LUCENE-774 and LUCENE-775 ...
just pointing that out for other people who might get confused.
2) since the new ScoreDoc.docComparator and ScoreDoc.scoreComparator are
public, they should have some javadocs clarifing what they are for.
3) i don't think the Hits.setSearcher method you added is safe ... i believe
that at a minimum hitDocs, first, last, and weight all need to be reset --
weight's a tricky one since the instance doesn't currently hang on to the
orriginal query.
4) I would personally prefer IndexWriterInterface and IndexModifierInterface
over InterfaceIndexWriter and InterfaceIndexModifier -- if for no other reason
then so they sort together .. but that's a minor nit.
I've only briefly looked at the new stuff in contrib, because I got lost ...
there isn't any package or class level javadocs or a build.xml in either
contrib. A big thing i did notice is that the code in indexfacade puts things
in the o.a.l.search and o.a.l.index packages, which is being discouraged for
contribs (among other reasons it makes it confusing to understand where a class
is coming form) ideally those classes should live under o.a.l.indexfacade.index
and o.a.l.indexfacade.index (or maybe just o.a.l.facade - but you get the idea)
> InstantiatedIndex - faster but memory consuming index
> -----------------------------------------------------
>
> Key: LUCENE-550
> URL: https://issues.apache.org/jira/browse/LUCENE-550
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Store
> Affects Versions: 2.0.0
> Reporter: Karl Wettin
> Assigned To: Karl Wettin
> Attachments: class_diagram.png, class_diagram.png,
> lucene.1.9-karl1.jpg, trunk.diff.bz2
>
>
> An non file centrinc all in memory index. Consumes some 2x the memory of a
> RAMDirectory (in a term satured index) but is between 3x-60x faster depending
> on application and how one counts. Average query is about 8x faster.
> IndexWriter and IndexModifier have been realized in InterfaceIndexWriter and
> InterfaceIndexModifier.
> InstantiatedIndex is wrapped in a new top layer index facade (class Index)
> that comes with factory methods for writers, readers and searchers for unison
> index handeling. There are decorators with notification handling that can be
> used for automatically syncronizing searchers on updates, et.c.
> Index also comes with FS/RAMDirectory implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
