[ 
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466927
 ] 

Hoss Man commented on LUCENE-781:
---------------------------------

i wasn't suggesting that the patch was flawed -- just trying to clarify what 
circumstances would cause an "NPE in MultiReader.isCurrent() and getVersion()"

it sounds like my comment has spawned a seperate issue...

if there are currently no tests for a multi-directory MultiReader then there 
certainly should be -- if the methods mentioned in this issue all currently 
throw an Exception on a multi-directory MultiReader we should either: a) define 
what the meaning of those methods is in that case, and implement them 
accordingly; or b) make those methods throw UnsupportedOperationException (or 
somethign similar) in thta case.


...either way, i'd still like clarification as to the orriginal point of this 
issue ... what was the bug?  what would trigger the NPE?

> NPE in MultiReader.isCurrent() and getVersion()
> -----------------------------------------------
>
>                 Key: LUCENE-781
>                 URL: https://issues.apache.org/jira/browse/LUCENE-781
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>            Reporter: Daniel Naber
>         Attachments: multireader.diff, multireader_test.diff
>
>
> I'm attaching a fix for the NPE in MultiReader.isCurrent() plus a testcase. 
> For getVersion(), we should throw a better exception that NPE. I will commit 
> unless someone objects or has a better idea.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to