I have a solution for the protection level (see my last comment on
adding an Interface), but not for the ThreadLocal issue in LazyField
construction (see the bug). I think I may just stick with the
original patch, unless someone has an insight. I guess I could pass
in the ThreadLocal and the cloneableFieldsStream, but that just feels
ugly and ripe for error, especially since the moving the LazyField
class into the FieldSelectorResult requires it be a private static
class.
On the other hand, I think it would be useful to eliminate the if/
else checks and allow for extending the types of FieldSelectorResults
w/o having to modify FieldsReader
Any opinion? If I/we don't come up w/ something by Wednesday, I will
commit the original patch so that we can go ahead with the release.
I could submit a "broken" patch that show what I have if that helps.
-Grant
On Feb 5, 2007, at 6:59 PM, Steven Parkes wrote:
I've been looking at 762. It does look a bit hairy, dealing with
all the
protection levels of the classes. Did you come up with an approach you
were happy with?
-----Original Message-----
From: Grant Ingersoll [mailto:[EMAIL PROTECTED]
Sent: Thursday, February 01, 2007 3:57 AM
To: java-dev@lucene.apache.org
Subject: Re: Lucene 2.1, soon
-1
I would like a few more days to get https://issues.apache.org/jira/
browse/LUCENE-762, as it may involve moving some classes and I don't
want to do that after an official release. It is not a major issue,
but I do think it is important to get right before the release.
Sorry for the delay.
Thanks,
Grant
On Feb 1, 2007, at 6:02 AM, Michael McCandless wrote:
Michael Busch wrote:
Michael McCandless wrote:
I plan on committing this one today. Once that's in I think we can
and should get the release process going (Yonik had graciously
volunteered to be the release manager)?
+1 for starting the release process. Especially the big new
features "lazy field loading", "lockless commits" and "delete in
IndexWriter" should make it a valuable upgrade for a lot of users.
Additionally, there have been various patches that improve
performance or prevent index corruption.
OK I just committed LUCENE-565 so I think we can get 2.1 started now?
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------
Grant Ingersoll
Center for Natural Language Processing
http://www.cnlp.org
Read the Lucene Java FAQ at http://wiki.apache.org/jakarta-lucene/
LuceneFAQ
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
------------------------------------------------------
Grant Ingersoll
http://www.grantingersoll.com/
http://www.paperoftheweek.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
