[ 
https://issues.apache.org/jira/browse/LUCENE-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475002
 ] 

Mark Miller commented on LUCENE-794:
------------------------------------

I have a patch coming tonight. It fixes a few odd mistakes and has a little 
more documentation. I had wanted to subpackage it into spanscorer for now, but 
it appears I can't make a patch with a new folder so that is out. Should I 
merge my package.html documentation with the one currently in highlighter? 
Also, I am not sure how a contrib that depends on another contrib should work 
build file wise (SpanScorer depends on MemoryIndex). I just made up something 
that works for now.

This new patch will be off the trunk so now the RangeQuery test fails as it 
does with the original QueryScorer...you cannot highlight a constantrangequery 
to my knowledge.

You also cannot ignore the fields in the query as you can with QueryScorer so 
that test fails. The only way that I can see doing this is to have the option 
in your query parser of ignoring all fields and just using one field name 
during parsing. Send the field-normal Query to search, and then make a 
field-neutered query for highlighting. That is the approach I will be taking 
with my query parser. I sure wish there was something better though.

Ill post the patch when I get out of work.

- Mark

> Beginnings of a span based highlighter
> --------------------------------------
>
>                 Key: LUCENE-794
>                 URL: https://issues.apache.org/jira/browse/LUCENE-794
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments: CachedTokenStream.java, CachedTokenStream.java, 
> CachedTokenStream.java, DefaultEncoder.java, Encoder.java, Formatter.java, 
> Highlighter.java, Highlighter.java, Highlighter.java, Highlighter.java, 
> Highlighter.java, HighlighterTest.java, HighlighterTest.java, 
> HighlighterTest.java, HighlighterTest.java, MemoryIndex.java, 
> QuerySpansExtractor.java, QuerySpansExtractor.java, QuerySpansExtractor.java, 
> QuerySpansExtractor.java, SimpleFormatter.java, SpanHighlighterTest.java, 
> SpanHighlighterTest.java, SpanScorer.java, SpanScorer.java, 
> WeightedSpanTerm.java
>
>
> This is some test code to start the work of adding a span based highlighting 
> approach to the existing highlighter in contrib. See 
> http://issues.apache.org/jira/browse/LUCENE-403 for some background.
> There is a dependency on MemoryIndex.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to