Actually, scratch that request. As long as they are package level, I
can put the class in the same package. Problem was that in the past
some important states fields have been private.
On Feb 22, 2007, at 4:04 PM, robert engels wrote:
I think the getters need to be public, as it makes many of the
'cache by segment' code much cleaner. Currently I cannot subclass
and must replace the class in the jar because I need access to much
o this information.
Is there some reason not to make the getters be public, (or copy on
read public)?
On Feb 22, 2007, at 3:56 PM, Michael McCandless (JIRA) wrote:
[ https://issues.apache.org/jira/browse/LUCENE-811?
page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-811:
--------------------------------------
Attachment: LUCENE-811.patch
Attaching proposed patch to change SegmentInfos (and all of its
methods/fields) back to package level protection.
I also found a few other cases (IndexFileNames,
IndexFileNamesFilter, SegmentInfo) that I had added public methods
which should be kept at package protection.
Public API inconsistency
------------------------
Key: LUCENE-811
URL: https://issues.apache.org/jira/browse/
LUCENE-811
Project: Lucene - Java
Issue Type: Bug
Components: Index
Affects Versions: 2.1
Environment: 2.1.0 release
Reporter: Andrzej Bialecki
Assigned To: Michael McCandless
Priority: Minor
Attachments: LUCENE-811.patch
org.apache.lucene.index.SegmentInfos is public, and contains
public methods (which is good for expert-level index manipulation
tools such as Luke). However, SegmentInfo class has package
visibility. This leads to a strange result that it's possible to
read SegmentInfos, but it's not possible to access its details
(SegmentInfos.info(int)) from a user application.
The solution is to make SegmentInfo class public.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
