[ 
https://issues.apache.org/jira/browse/LUCENE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477919
 ] 

Doron Cohen commented on LUCENE-814:
------------------------------------

The modified selector worked ok with the default cache file, so I thught the 
problem was with using a different cache file.

I also suspected the modification time granularity, but adding a sleep between 
the first and second date selector did not overcome that. Actually, I thought 
that this granularity issue would cause the oposite problem - changed files to 
appear as if they did not change, thus added the delay.

I also considered the regexp "Genereated By JavaCC" selector, but then found 
out that there are more files (7) containing this string than files that are 
currently generated by JavaCC task (4) - removing all those files, running 
javacc-QueryParser did not recreate all of them.

grep -ni "generated by:.*javacc" *.java
    CharStream.java:1:/* Generated By:JavaCC: Do not edit this line. 
CharStream.java Version 3.0 */
    ParseException.java:1:/* Generated By:JavaCC: Do not edit this line. 
ParseException.java Version 3.0 */
    QueryParser.java:1:/* Generated By:JavaCC: Do not edit this line. 
QueryParser.java */ 
    QueryParserConstants.java:1:/* Generated By:JavaCC: Do not edit this line. 
QueryParserConstants.java */
    QueryParserTokenManager.java:1:/* Generated By:JavaCC: Do not edit this 
line. QueryParserTokenManager.java */
    Token.java:1:/* Generated By:JavaCC: Do not edit this line. Token.java 
Version 3.0 */
    TokenMgrError.java:1:/* Generated By:JavaCC: Do not edit this line. 
TokenMgrError.java Version 3.0 */

So it seemed unreliable to rely on the presense of this string.

> javacc on Win32 (cygwin) creates wrong line endings - fix them with 'ant 
> replace'
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-814
>                 URL: https://issues.apache.org/jira/browse/LUCENE-814
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Build
>         Environment: Windows, Cygwin
>            Reporter: Doron Cohen
>         Assigned To: Doron Cohen
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: 814.javacc.fixcrlf.common-build.patch, 
> 814.javacc.fixcrlf.common-build.patch, 814.javacc.line.ends.patch, 
> LUCENE-814.txt, LUCENE-814.txt
>
>
> "ant javacc" in Windows/Cygwin generates files with wrong line endings (\r  
> or \r\n instead of *Nix's \n). 
> I managed to get rid of those using    perl -p -e 's/(\r\n|\n|\r)/\n/g'
> Some useful info on line ending issues is in 
> http://en.wikipedia.org/wiki/Newline
> After wasting some time to get rid of those, I modified javacc-QueryParser 
> build.xml task to take care of that.
> So now QueryParser files created with "ant javacc" are fixed (if required) to 
> have \n as line ends.
> Should probably do that also for the other javacc targets: javacc-HTMLParser 
> and javacc-StandardAnalyzer(?)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to