Erik and Chris,

Thank you for reviewing this.  All is good now.

  Mike


Erik Hatcher wrote:

On Mar 6, 2007, at 2:27 PM, Chris Hostetter wrote:
:    PFRegexCapabilities.java:3:
: org.apache.lucene.search.regex.RegexCapabilities is not public in
: org.apache.lucene.search.regex; cannot be accessed from outside package

It looks like this *may* have been a mistake, the commit message says
"Many javadoc additions, and adding ASL to each file" ...

http://svn.apache.org/viewvc/lucene/java/trunk/contrib/regex/src/java/org/apache/lucene/search/regex/RegexCapabilities.java?r1=359526&r2=381108

...but one other interfaces changed from being public to package
protecte at the same time: RegexQueryCapable ... so it's not clear to me
wether this was a concious choice to "protect" the API or not.

Erik?

For some reason I had been thinking that interfaces were always public, but I removed my ignorance (all methods are implicitly public, but the interface itself is not). I've just committed a change to make these two interfaces public - no reason not to. Interestingly, one of them was already public locally which confused me a bit as well.

Anyway, all public now!

Sorry for the confusion, Mike.

    Erik




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to