[
https://issues.apache.org/jira/browse/LUCENE-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483413
]
Doron Cohen commented on LUCENE-837:
------------------------------------
Hi, I like the new field selector stuff.
Few comments:
- copyright notice missing in the new ***Selector class
- The bytes storing in BasicDocMaker - perhaps better to extract the bytes in
BasicDocMaker, - just before the closing '}' of
if (docData.body!=null && docData.body.length()>0) {
just taking bdy.getBytes("UTF-8").
This way this too would respect the doc size limitation parameter.
This would actually allow all doc makers to support this, and you can undo
the changes to DocData and to ReutersDocMaker.
Hope I got it right?
- Would you like to add the new task to list in TestPerfTasksParse, with no
parameters and with some parameters?
(it should be anyhow parse-tested now automatically, but with no params.)
- the meaning of the new reuters.doc.maker.store.bytes property is: also store
the
entire doc content as a raw bytes field, right? (It was not clear to from the
javadoc.)
Regards,
Doron
> contrib/benchmark QueryMaker and Task Refactorings
> --------------------------------------------------
>
> Key: LUCENE-837
> URL: https://issues.apache.org/jira/browse/LUCENE-837
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/benchmark
> Reporter: Grant Ingersoll
> Assigned To: Grant Ingersoll
> Priority: Minor
> Attachments: benchmark-more-updates.patch, benchmark-updates.patch,
> field-selector-bench.patch
>
>
> Introduce an abstract QueryMaker implementation that shares much of the
> common code between the various QueryMaker implementations.
> Add in a new QueryMaker for reading queries from a file that is specified in
> the properties.
> Patch shortly, and if no concerns, will commit tomorrow or Wed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
