Well, with all due respect, I don't find whitespace malignant ... That said, I don't get into this anymore. I make all the necessary whitespace changes at the end. When making a candidate patch, I go through it line by line looking for whitespace/style changes that I've inadvertently added and take them out. In a case like this, where I've been writing something from scratch, I just take a valium first.
It's no big deal to me. -----Original Message----- From: Michael McCandless (JIRA) [mailto:[EMAIL PROTECTED] Sent: Sunday, March 25, 2007 5:49 AM To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-847) Factor merge policy out of IndexWriter [ https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira .plugin.system.issuetabpanels:comment-tabpanel#action_12483930 ] Michael McCandless commented on LUCENE-847: ------------------------------------------- My first comment, which I fear will be the most controversial feedback here :), is a whitespace style question: I'm not really a fan of "cancerous whitespace" where every ( [ etc has its own whitespace around it. I generally prefer minimal whitespace within reason (ie as long as it does not heavily hurt readability). The thing is I don't know that Lucene has settled on this / if anyone else shares my opinion? It does seem that "two space indentation" is the standard, which I agree with, but I don't know if whitespace style has otherwise been agreed on? Many people will say it's unimportant to agree on whitespace but I feel it's actually quite important. > Factor merge policy out of IndexWriter > -------------------------------------- > > Key: LUCENE-847 > URL: https://issues.apache.org/jira/browse/LUCENE-847 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Steven Parkes > Assigned To: Steven Parkes > Attachments: LUCENE-847.txt > > > If we factor the merge policy out of IndexWriter, we can make it pluggable, making it possible for apps to choose a custom merge policy and for easier experimenting with merge policy variants. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
