[
https://issues.apache.org/jira/browse/LUCENE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484546
]
Michael McCandless commented on LUCENE-431:
-------------------------------------------
Michael, the patch problem seems to be something on my end, which I can't yet
explain.
When I take your zip (thanks!), unzip into a fresh trunk checkout, run 'svn
diff', take the output to another fresh trunk checkout, and try to apply that
patch, I get the same error. Somehow my version of patch (2.5.4 on Debian)
cannot handle the output of 'svn diff'. Spooky!
> RAMInputStream and RAMOutputStream without further buffering
> ------------------------------------------------------------
>
> Key: LUCENE-431
> URL: https://issues.apache.org/jira/browse/LUCENE-431
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Store
> Affects Versions: CVS Nightly - Specify date in submission
> Environment: Operating System: other
> Platform: Other
> Reporter: Paul Elschot
> Assigned To: Michael Busch
> Priority: Minor
> Attachments: lucene-431.patch, lucene-431.zip, RAMInputStream.java
>
>
> From java-dev, Doug's reply of 12 Sep 2005
> on Delaying buffer allocation in BufferedIndexInput:
>
> Paul Elschot wrote:
> ...
> > I noticed that RAMIndexInput extends BufferedIndexInput.
> > It has all data in buffers already, so why is there another
> > layer of buffering?
>
> No good reason: it's historical.
>
> To avoid this either: (a) the BufferedIndexInput API would need to be
> modified to permit subclasses to supply the buffer; or (b)
> RAMInputStream could subclass IndexInput directly, using its own
> buffers. The latter would probably be simpler.
>
> End of quote.
>
> I made version (b) of RAMInputStream.
> Using this RAMInputStream, TestTermVectorsReader failed as the only
> failing test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
