[ 
https://issues.apache.org/jira/browse/LUCENE-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487679
 ] 

Hoss Man commented on LUCENE-857:
---------------------------------

I don't think it's a question of being careless about reading the Changelog -- 
I just think that when dealing with a point release, we shouldn't require 
people to make code changes just to get the same behavior as before ... if this 
was necessary to fix a bug it would be one thing, but really what we're talking 
about here is refactoring out a piece of functionality (using a Query as a 
Filter) so that it can be used independently from another piece of 
functionality (filter caching) ... since that can be done in a backwards 
compatible way, why not make it easy for people.

> With your suggestion one can't get a raw QueryFilter without getting it 
> automatically cached. Isn't this inflexibility uncool? 

...not quite, I'm suggesting that the "raw" QueryFilter behavior be extracted 
into a new class (QueryWrapperFilter) and the existing QueryFilter class 
continue to do exactly what it currently does - but refactored so that there is 
no duplicate code.

> Remove BitSet caching from QueryFilter
> --------------------------------------
>
>                 Key: LUCENE-857
>                 URL: https://issues.apache.org/jira/browse/LUCENE-857
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Otis Gospodnetic
>         Assigned To: Otis Gospodnetic
>            Priority: Minor
>         Attachments: LUCENE-857.patch
>
>
> Since caching is built into the public BitSet bits(IndexReader reader)  
> method, I don't see a way to deprecate that, which means I'll just cut it out 
> and document it in CHANGES.txt.  Anyone who wants QueryFilter caching will be 
> able to get the caching back by wrapping the QueryFilter in the 
> CachingWrapperFilter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to