[ 
https://issues.apache.org/jira/browse/LUCENE-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502704
 ] 

Paul Elschot commented on LUCENE-912:
-------------------------------------

> > I'm not sure, but the patch allows to increment all generators right after 
> > the first time, and that might cause it to make a mistake in the score 
> > computation for its first doc.

This is from code inspection only, I have no test cases showing wrong behaviour:
What I meant is that during DisjunctionMaxScorer.next() initially the 
subscorers have next() called on them, so they are at their first docs, and 
then during next() (with the return statement deleted) the "generators are 
incremented again" even when at firstTime. That means that the score() might be 
computed on the wrong subscorer docs after the first call to next().

But this issue is about DisjunctionMaxScorer.skipTo(), and removing the 
firstTime return statement there is correct I think.



> DisjunctionMaxScorer.skipTo has bug that keeps it from skipping
> ---------------------------------------------------------------
>
>                 Key: LUCENE-912
>                 URL: https://issues.apache.org/jira/browse/LUCENE-912
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1
>            Reporter: Hoss Man
>            Assignee: Doron Cohen
>             Fix For: 2.2
>
>         Attachments: checkTwoCallsToScore.patch, checkTwoCallsToScore.patch, 
> dismax_skipto.patch, lucene-912.patch
>
>
> as reported on the mailing list, DisjunctionMaxScorer.skipTo is broken if 
> called before next in some situations...
> http://www.nabble.com/Potential-issue-with-DisjunctionMaxScorer-tf3846366.html#a10894987

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to