[ 
https://issues.apache.org/jira/browse/LUCENE-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man updated LUCENE-743:
----------------------------

    Attachment: lucene-743.patch

an extremely hackish refactoring of the previous patch that demonstrates the 
method working recursively and dealing with MultiReaders constructed over 
multiple subReaders.

a few notes:

1) no where near enough tests of the subReader situation
2) the refactoring is very very ugly and brutish ... most of the code is still 
in IndexReader just because it needs so many things that are private -- things 
that really seems like they should be pushed down into SegmentReader (or made 
protected)
3) test triggered an apparent NPE in MultiReader.isOptimized() when there are 
subReaders, i hacked arround this in the test, see usages of 
assertIndexEqualsZZZ vs assertIndexEquals
4) the FilterIndexReader situation is ... interesting.  in theory 
FilterIndexReader should really be abstract (since if you aren't subclassing it 
anyway, why do you want it?) 


> IndexReader.reopen()
> --------------------
>
>                 Key: LUCENE-743
>                 URL: https://issues.apache.org/jira/browse/LUCENE-743
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Otis Gospodnetic
>            Assignee: Michael Busch
>            Priority: Minor
>         Attachments: IndexReaderUtils.java, lucene-743.patch, 
> lucene-743.patch, MyMultiReader.java, MySegmentReader.java
>
>
> This is Robert Engels' implementation of IndexReader.reopen() functionality, 
> as a set of 3 new classes (this was easier for him to implement, but should 
> probably be folded into the core, if this looks good).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to