[
https://issues.apache.org/jira/browse/LUCENE-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515911
]
Otis Gospodnetic commented on LUCENE-794:
-----------------------------------------
Mark, wow, long list of files up there. I can't tell which ones are still
relevant. Ah, only spanhighlighter9.patch, right?
It looks like all files in that patch are new files, that is, this is a
parallel highlighter implementation - we can leave the old one in there and
commit yours without worrying about breaking the old one. Could you add Apache
license headers to all files, switch to 2 spaces for indentation, and then I
think this can get committed?
Oh, and since contrib can be java 1.5+, I think you can use StringBuilder
instead of StringBuffer, etc.
> Extend contrib Highlighter to properly support phrase queries and span queries
> ------------------------------------------------------------------------------
>
> Key: LUCENE-794
> URL: https://issues.apache.org/jira/browse/LUCENE-794
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Reporter: Mark Miller
> Priority: Minor
> Attachments: CachedTokenStream.java, CachedTokenStream.java,
> CachedTokenStream.java, DefaultEncoder.java, Encoder.java, Formatter.java,
> Highlighter.java, Highlighter.java, Highlighter.java, Highlighter.java,
> Highlighter.java, HighlighterTest.java, HighlighterTest.java,
> HighlighterTest.java, HighlighterTest.java, MemoryIndex.java,
> QuerySpansExtractor.java, QuerySpansExtractor.java, QuerySpansExtractor.java,
> QuerySpansExtractor.java, SimpleFormatter.java, spanhighlighter.patch,
> spanhighlighter2.patch, spanhighlighter3.patch, spanhighlighter5.patch,
> spanhighlighter6.patch, spanhighlighter7.patch, spanhighlighter8.patch,
> spanhighlighter9.patch, spanhighlighter_patch_4.zip,
> SpanHighlighterTest.java, SpanHighlighterTest.java, SpanScorer.java,
> SpanScorer.java, WeightedSpanTerm.java
>
>
> This patch adds a new Scorer class (SpanQueryScorer) to the Highlighter
> package that scores just like QueryScorer, but scores a 0 for Terms that did
> not cause the Query hit. This gives 'actual' hit highlighting for the range
> of SpanQuerys and PhraseQuery. There is also a new Fragmenter that attempts
> to fragment without breaking up Spans.
> See http://issues.apache.org/jira/browse/LUCENE-403 for some background.
> There is a dependency on MemoryIndex.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
