[
https://issues.apache.org/jira/browse/LUCENE-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Elschot updated LUCENE-584:
--------------------------------
Attachment: Matcher3-core-20070730.patch
Matcher2-default-20070730.patch
Matcher1-ground-20070730.patch
A different take in the patches of 20070730.
In this version class Filter has only one method:
public abstract Matcher getMatcher(IndexReader).
Class BitSetFilter is added as a subclass of Filter, and it has the familiar
public abstract BitSet bits(IndexReader),
as well as a default implementation of the getMatcher() method.
In the ..core.. patch, and in the ..contrib.. patches (to follow), most uses of
Filter simply replaced by BitSetFilter. This turned out to be an easy way of
dealing
with this API change in Filter.
This change to Filter and its replacement by BitSetFilter could well be taking
things too far for now, and I'd like to know whether other approaches
are preferred.
The ..default.. patch contains a default implementation of a Matcher from a
BitSet, and it has OpenBitSet and friends from solr, as well as SortedVIntList
as posted earlier.
> Decouple Filter from BitSet
> ---------------------------
>
> Key: LUCENE-584
> URL: https://issues.apache.org/jira/browse/LUCENE-584
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.0.1
> Reporter: Peter Schäfer
> Priority: Minor
> Attachments: bench-diff.txt, bench-diff.txt,
> Matcher-core20070725.patch, Matcher-default20070725.patch,
> Matcher-ground20070725.patch, Matcher1-ground-20070730.patch,
> Matcher2-default-20070730.patch, Matcher3-core-20070730.patch, Some
> Matchers.zip
>
>
> {code}
> package org.apache.lucene.search;
> public abstract class Filter implements java.io.Serializable
> {
> public abstract AbstractBitSet bits(IndexReader reader) throws IOException;
> }
> public interface AbstractBitSet
> {
> public boolean get(int index);
> }
> {code}
> It would be useful if the method =Filter.bits()= returned an abstract
> interface, instead of =java.util.BitSet=.
> Use case: there is a very large index, and, depending on the user's
> privileges, only a small portion of the index is actually visible.
> Sparsely populated =java.util.BitSet=s are not efficient and waste lots of
> memory. It would be desirable to have an alternative BitSet implementation
> with smaller memory footprint.
> Though it _is_ possibly to derive classes from =java.util.BitSet=, it was
> obviously not designed for that purpose.
> That's why I propose to use an interface instead. The default implementation
> could still delegate to =java.util.BitSet=.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
