[
https://issues.apache.org/jira/browse/LUCENE-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536827
]
Michael McCandless commented on LUCENE-743:
-------------------------------------------
{quote}
* MultiReader/ParallelReader must not incref the subreaders on open()
as you said. But on reopen() it must incref the subreaders that
haven't changed and thus are shared with the old MultiReader/
ParallelReader. This further means, that the re-opened MultiReader/
ParallelReader must remember which of the subreaders to decref on
close(), right?
{quote}
Hmm, right. MultiReader/ParallelReader must keep track of whether it
should call decref() or close() on each of its child readers, when it
itself is closed.
{quote}
* If we change ensureOpen() like you suggest, then the user might
still be able to use reader1 (in my example), even after
reader1.close() was explicitly called. Probably not a big deal?
{quote}
I think this is OK?
> IndexReader.reopen()
> --------------------
>
> Key: LUCENE-743
> URL: https://issues.apache.org/jira/browse/LUCENE-743
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Otis Gospodnetic
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.3
>
> Attachments: IndexReaderUtils.java, lucene-743-take2.patch,
> lucene-743.patch, lucene-743.patch, lucene-743.patch, MyMultiReader.java,
> MySegmentReader.java, varient-no-isCloneSupported.BROKEN.patch
>
>
> This is Robert Engels' implementation of IndexReader.reopen() functionality,
> as a set of 3 new classes (this was easier for him to implement, but should
> probably be folded into the core, if this looks good).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
