[
https://issues.apache.org/jira/browse/LUCENE-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547673
]
Doron Cohen commented on LUCENE-1019:
-------------------------------------
{quote}
* The way in which caching is handled is now unclear.
{quote}
For e.g. IntFieldSource caching is done in that level, so I am not sure
I understand about what is unclear here.
{quote}
* Trying to get explain information from the sub-ValueSources was quite
difficult.
* There is much more code in my queries, leading to increased brittleness.
{quote}
Yes I agree about this part.
I had the similar experience when combining field values, and decided to just
live with that.
In a glance, the v2 patch seems to solve this nicely so I will look into
committing this.
Thanks for bringing this up,
Doron
> CustomScoreQuery should support multiple ValueSourceQueries
> -----------------------------------------------------------
>
> Key: LUCENE-1019
> URL: https://issues.apache.org/jira/browse/LUCENE-1019
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.2
> Reporter: Kyle Maxwell
> Attachments: CustomMultiQuery.v0.diff, CustomScoreQuery.v1.diff
>
>
> CustomScoreQuery's constructor currently accepts a subQuery, and a
> ValueSourceQuery. I would like it to accept multiple ValueSourceQueries.
> The workaround of nested CustomScoreQueries works for simple cases, but it
> quickly becomes either cumbersome to manage, or impossible to implement the
> desired function.
> This patch implements CustomMultiScoreQuery with my desired functionality,
> and refactors CustomScoreQuery to implement the special case of a
> CustomMultiScoreQuery with 0 or 1 ValueSourceQueries. This keeps the
> CustomScoreQuery API intact.
> This patch includes basic tests, more or less taken from the original
> implementation, and customized a bit to cover the new cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
