On Dec 26, 2007, at 6:20 PM, Doron Cohen wrote:
Working on Lucene-1101 I checked if SinkTokenizer.next(Token) should
also
call Token.clear(). (It shouldn't, because it ignores the input
token.)
However I think that calls to next() would end up creating Tokens for
nothing (by TokenStream.next()).
May currently be an empty case (if all current uses call
next(Token)), but
still - is it safer for SinkTokenizer to implement next() rather than
next(Token)?
I'm still a bit fuzzy on the interplay of these myself, but what makes
the call of SinkTokenizer.next(Token) unsafe or is it just the
potential of Tokens being created? I guess SinkTokenizer could just
override both methods.
-Grant
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
