[
https://issues.apache.org/jira/browse/LUCENE-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557723#action_12557723
]
Michael Busch commented on LUCENE-1125:
---------------------------------------
{quote}
The fix is very low risk. All tests pass.
{quote}
Yes, all contrib & core tests pass for me too. And after reading the
patch I agree that it looks good and is low risk.
{quote}
Michael, I think we should spin 2.3 RC2 to include this fix? Sorry to
only find it so late in the game
{quote}
OK, why don't you commit this today. Meanwhile I'll look into the
small issues Hoss pointed out and then build RC2 end of today.
Oh, and no need to be sorry! This is what the code freeze period is
for - finding and fixing problems! :-)
> Excessive Arrays.fill(0) in DocumentsWriter drastically slows down small docs
> (3.9X slowdown!)
> ----------------------------------------------------------------------------------------------
>
> Key: LUCENE-1125
> URL: https://issues.apache.org/jira/browse/LUCENE-1125
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Affects Versions: 2.3
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.3
>
> Attachments: LUCENE-1125.patch
>
>
> I've been doing some "final" performance testing of 2.3RC1 and
> uncovered a fairly serious bug that adds a large fixed CPU cost when
> documents have any term vector enabled fields.
> The bug does not affect correctness, just performance.
> Basically, for every document, we were calling Arrays.fill(0) on a
> large (32 KB) byte array when in fact we only needed to zero a small
> part of it. This only happens if term vectors are turned on, and is
> especially devastating for small documents.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
