[ 
https://issues.apache.org/jira/browse/LUCENE-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563106#action_12563106
 ] 

Nicolas Dessaigne commented on LUCENE-794:
------------------------------------------

Mark,

I added a few lines of code to the WeightedSpanTermExtractor.extract method to 
handle DisjunctionMaxQuery instances. I didn't take the time to make a patch 
against your new version but the code is pretty simple:

{code}
...
} else if (query instanceof DisjunctionMaxQuery) {}}
        Map disjunctTerms = new HashMap();
        for (Iterator iterator = ((DisjunctionMaxQuery) query).iterator(); 
iterator.hasNext();) {
                extract((Query) iterator.next(), disjunctTerms);
        }
        terms.putAll(disjunctTerms);
} else {
...
{code}

> Extend contrib Highlighter to properly support phrase queries and span queries
> ------------------------------------------------------------------------------
>
>                 Key: LUCENE-794
>                 URL: https://issues.apache.org/jira/browse/LUCENE-794
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments: SpanHighlighter-01-26-2008.patch, spanhighlighter.patch, 
> spanhighlighter10.patch, spanhighlighter11.patch, spanhighlighter12.patch, 
> spanhighlighter2.patch, spanhighlighter3.patch, spanhighlighter5.patch, 
> spanhighlighter6.patch, spanhighlighter7.patch, spanhighlighter8.patch, 
> spanhighlighter9.patch, spanhighlighter_24_January_2008.patch, 
> spanhighlighter_patch_4.zip
>
>
> This patch adds a new Scorer class (SpanQueryScorer) to the Highlighter 
> package that scores just like QueryScorer, but scores a 0 for Terms that did 
> not cause the Query hit. This gives 'actual' hit highlighting for the range 
> of SpanQuerys and PhraseQuery. There is also a new Fragmenter that attempts 
> to fragment without breaking up Spans.
> See http://issues.apache.org/jira/browse/LUCENE-403 for some background.
> There is a dependency on MemoryIndex.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to