[
https://issues.apache.org/jira/browse/LUCENE-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570505#action_12570505
]
Mark Harwood commented on LUCENE-794:
-------------------------------------
Couple of quick comments from a first look.
* I amended the new unit test, stripped out all new "Span" related tests and
compared running it against 2.3 highlighter code and this patch. On this rough
test it looks like the new implementation is slightly faster executing these
tests (2.6 seconds vs 3.0). Good stuff.
* The general advice on using the Highlighter is to call it with re-written
queries in order to highlight fuzzy queries etc. That being the case, the
support for ConstantScoreRangeQuery in WeightedSpanTermExtractor is not likely
to work because ConstantScoreRangeQuery rewrites to a ConstantScoreQuery and
therefore can't be inspected for terms.
Hope to spend some more time looking at this tomorrow.
> Extend contrib Highlighter to properly support PhraseQuery, SpanQuery,
> ConstantScoreRangeQuery
> -----------------------------------------------------------------------------------------------
>
> Key: LUCENE-794
> URL: https://issues.apache.org/jira/browse/LUCENE-794
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Reporter: Mark Miller
> Priority: Minor
> Attachments: SpanHighlighter-01-26-2008.patch,
> SpanHighlighter-01-28-2008.patch, spanhighlighter.patch,
> spanhighlighter10.patch, spanhighlighter11.patch, spanhighlighter12.patch,
> spanhighlighter2.patch, spanhighlighter3.patch, spanhighlighter5.patch,
> spanhighlighter6.patch, spanhighlighter7.patch, spanhighlighter8.patch,
> spanhighlighter9.patch, spanhighlighter_24_January_2008.patch,
> spanhighlighter_patch_4.zip
>
>
> This patch adds a new Scorer class (SpanQueryScorer) to the Highlighter
> package that scores just like QueryScorer, but scores a 0 for Terms that did
> not cause the Query hit. This gives 'actual' hit highlighting for the range
> of SpanQuerys, PhraseQuery, and ConstantScoreRangeQuery. New Query types are
> easy to add. There is also a new Fragmenter that attempts to fragment without
> breaking up Spans.
> See http://issues.apache.org/jira/browse/LUCENE-403 for some background.
> There is a dependency on MemoryIndex.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
