[ https://issues.apache.org/jira/browse/LUCENE-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1184: --------------------------------------- Attachment: LUCENE-1184.patch Attached patch. I plan to commit in a day or two. > Allow SnapshotDeletionPolicy to be reused across writer close/open > ------------------------------------------------------------------ > > Key: LUCENE-1184 > URL: https://issues.apache.org/jira/browse/LUCENE-1184 > Project: Lucene - Java > Issue Type: Improvement > Components: Index > Affects Versions: 2.3 > Reporter: Michael McCandless > Assignee: Michael McCandless > Priority: Minor > Fix For: 2.4 > > Attachments: LUCENE-1184.patch > > > If you re-use the same instance of SnapshotDeletionPolicy across a > close/open of your writer, and you had a snapshot open, it can still > be removed when the 2nd writer is opened. This is because SDP is > comparing IndexCommitPoint instances. > The fix is to instead compare segments file names. > I've also changed the inner class IndexFileDeleter.CommitPoint to be > static so an instance of SnapshotDeletionPolicy does not hold > references to IndexFileDeleter, DocumentsWriter, etc. > Spinoff from here: > http://markmail.org/message/bojgqfgyxkkv4fyb -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]